Wrong loop in the BSE

You can find here problems arising when using old releases of Yambo (< 5.0). Issues as parallelization strategy, performance issues and other technical aspects.

Moderators: Davide Sangalli, andrea.ferretti, myrta gruning, andrea marini, Daniele Varsano, Conor Hogan

Locked
User avatar
claudio
Posts: 528
Joined: Tue Mar 31, 2009 11:33 pm
Location: Marseille
Contact:

Wrong loop in the BSE

Post by claudio » Tue Jun 13, 2017 9:04 pm

Hi again

I just report you another small bug in K_correlation_collisions.F

the loop in line 149 for the c->c' case is never executed

Code: Select all

do i_block_p=i_block,i_block,-1
    ....
enddo
I changed in

Code: Select all

do i_block_p=i_block,1,-1
    ....
enddo
like for the valence bands.

Ciao
Claudio
Claudio Attaccalite
[CNRS/ Aix-Marseille Université/ CINaM laborarory / TSN department
Campus de Luminy – Case 913
13288 MARSEILLE Cedex 09
web site: http://www.attaccalite.com

User avatar
Davide Sangalli
Posts: 641
Joined: Tue May 29, 2012 4:49 pm
Location: Via Salaria Km 29.3, CP 10, 00016, Monterotondo Stazione, Italy
Contact:

Re: Wrong loop in the BSE

Post by Davide Sangalli » Sat Jul 29, 2017 8:54 am

Thanks Claudio,
this should have been already fixed in yambo 4.1.4

D.
Davide Sangalli, PhD
CNR-ISM, Division of Ultrafast Processes in Materials (FLASHit) and MaX Centre
https://sites.google.com/view/davidesangalli
http://www.max-centre.eu/

Locked